Re: [PATCH net-next 1/3] vsock: add network namespace support

From: David Miller
Date: Mon Jan 20 2020 - 04:06:16 EST


From: Stefano Garzarella <sgarzare@xxxxxxxxxx>
Date: Thu, 16 Jan 2020 18:24:26 +0100

> This patch adds 'netns' module param to enable this new feature
> (disabled by default), because it changes vsock's behavior with
> network namespaces and could break existing applications.

Sorry, no.

I wonder if you can even design a legitimate, reasonable, use case
where these netns changes could break things.

I am totally against adding a module parameter for this, it's
incredibly confusing for users and will create a test scenerio
that is strongly less likely to be covered.