Re: [PATCH v1 2/7] mtd: rawnand: add unspecified HAS_IOMEM dependency

From: Miquel Raynal
Date: Sat Jan 25 2020 - 10:28:17 EST


Hi Brendan,

Brendan Higgins <brendanhiggins@xxxxxxxxxx> wrote on Fri, 24 Jan 2020
18:12:12 -0800:

> On Thu, Jan 9, 2020 at 7:23 AM Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:
> >
> > Hi Brendan,
> >
> > Brendan Higgins <brendanhiggins@xxxxxxxxxx> wrote on Wed, 11 Dec 2019
> > 11:27:37 -0800:
> >
> > > Currently CONFIG_MTD_NAND_CADENCE implicitly depends on
> > > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> > > the following build error:
> > >
> > > ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31':
> > > drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource'
> > > ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource'
> > >
> > > Fix the build error by adding the unspecified dependency.
> > >
> > > Reported-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>
> > > Signed-off-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>
> > > ---
> >
> > Sorry for the delay.
> >
> > Acked-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
>
> It looks like my change has not been applied to nand/next; is this the
> branch it should be applied to? I have also verified that this patch
> isn't in linux-next as of Jan 24th.
>
> Is mtd/linux the correct tree for this? Or do I need to reach out to
> someone else?

When I sent my Acked-by I supposed someone else would pick the patch,
but there is actually no dependency with all the other patches so I
don't know why I did it... Sorry about that. I'll take it anyway in my
PR for 5.6.

Thanks,
MiquÃl