Re: [PATCH 4.19 587/639] net: stmmac: gmac4+: Not all Unicast addresses may be available

[Pavel Machek]

Hi!

> Some setups may not have all Unicast addresses filters available. Check
> the number of available filters before trying to setup it.
...
> @@ -443,7 +443,7 @@ static void dwmac4_set_filter(struct mac_device_info *hw,
>  	}
>  
>  	/* Handle multiple unicast addresses */
> -	if (netdev_uc_count(dev) > GMAC_MAX_PERFECT_ADDRESSES) {
> +	if (netdev_uc_count(dev) > hw->unicast_filter_entries) {
>  		/* Switch to promiscuous mode if more than 128 addrs
>  		 * are required
>  		 */

Do I understand correctly that 128 in the comment is no longer
accurate?

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: PGP signature