Re: [PATCH] net/mlx5: Remove a useless 'drain_workqueue()' call in 'mlx5e_ipsec_cleanup()'

[Boris Pismenny]

On 1/26/2020 7:51 PM, Christophe JAILLET wrote:
> 'destroy_workqueue()' already calls 'drain_workqueue()', there is no need
> to call it explicitly.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c
> index cf58c9637904..29626c6c9c25 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c
> @@ -433,7 +433,6 @@ void mlx5e_ipsec_cleanup(struct mlx5e_priv *priv)
>  	if (!ipsec)
>  		return;
>  
> -	drain_workqueue(ipsec->wq);
>  	destroy_workqueue(ipsec->wq);
>  
>  	ida_destroy(&ipsec->halloc);
LGTM