Re: [PATCH 3/9] mmc: mmci: add a reference at mmc_host_ops in mmci struct

[Ludovic BARRE]

Le 1/24/20 Ã 2:09 PM, Ulf Hansson a ÃcritÂ:
> On Fri, 10 Jan 2020 at 14:49, Ludovic Barre <ludovic.barre@xxxxxx> wrote:
> > This patch adds mmc_host_ops pointer in mmci struct.
> > The variant init function may need to add a mmc_host_ops,
> > for example to add the execute_tuning support if this feature
> > is available.
> >
> > Signed-off-by: Ludovic Barre <ludovic.barre@xxxxxx>
> > ---
> >   drivers/mmc/host/mmci.c | 1 +
> >   drivers/mmc/host/mmci.h | 1 +
> >   2 files changed, 2 insertions(+)
> >
> > diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
> > index 7b13d66cbb21..00b473f57047 100644
> > --- a/drivers/mmc/host/mmci.c
> > +++ b/drivers/mmc/host/mmci.c
> > @@ -1923,6 +1923,7 @@ static int mmci_probe(struct amba_device *dev,
> >
> >          host = mmc_priv(mmc);
> >          host->mmc = mmc;
> > +       host->mmc_ops = &mmci_ops;
>
> Nitpick:
>
> Can you please also move the assignment "mmc->ops = &mmci_ops;" to
> this place as well, as I think these belongs together.

OK

> >          /*
> >           * Some variant (STM32) doesn't have opendrain bit, nevertheless
> > diff --git a/drivers/mmc/host/mmci.h b/drivers/mmc/host/mmci.h
> > index ea6a0b5779d4..55acc0971a44 100644
> > --- a/drivers/mmc/host/mmci.h
> > +++ b/drivers/mmc/host/mmci.h
> > @@ -407,6 +407,7 @@ struct mmci_host {
> >          u32                     mask1_reg;
> >          u8                      vqmmc_enabled:1;
> >          struct mmci_platform_data *plat;
> > +       struct mmc_host_ops     *mmc_ops;
> >          struct mmci_host_ops    *ops;
> >          struct variant_data     *variant;
> >          struct pinctrl          *pinctrl;
> > --
> > 2.17.1
>
> Kind regards
> Uffe