Re: [PATCH 1/2] ima: use the IMA configured hash algo to calculate the boot aggregate

[Mimi Zohar]

On Mon, 2020-01-27 at 13:16 -0500, Mimi Zohar wrote:
> On Mon, 2020-01-27 at 17:38 +0000, Roberto Sassu wrote:
> > > -----Original Message-----
> > > From: linux-integrity-owner@xxxxxxxxxxxxxxx [mailto:linux-integrity-
> > > owner@xxxxxxxxxxxxxxx] On Behalf Of Mimi Zohar
> > > Sent: Monday, January 27, 2020 5:02 PM
> > > To: linux-integrity@xxxxxxxxxxxxxxx
> > > Cc: Jerry Snitselaar <jsnitsel@xxxxxxxxxx>; James Bottomley
> > > <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>; linux-
> > > kernel@xxxxxxxxxxxxxxx; Mimi Zohar <zohar@xxxxxxxxxxxxx>
> > > Subject: [PATCH 1/2] ima: use the IMA configured hash algo to calculate the
> > > boot aggregate
> > 
> > Hi Mimi
> > 
> > I did a similar change (patch 8/8) in the patch set I just sent. The patch is simpler,
> > as it reuses the data structures I introduced in the previous patches. Let me know
> > if I can keep this part in my patch set or I should remove it.
> 
> Only 2/2 "ima: support calculating the boot_aggregate based on
> different TPM banks" is really needed to address Jerry's bug report.
> ÂLet's review your patch set before making any decisions about 1/2
> "ima: use the IMA configured hash algo to calculate the boot
> aggregate".

To be more precise, we need to be able to backport the bug fix. ÂSo
the change needs to be independent of anything you're defining now.
ÂChanges/improvements can be made on top of the bug fix.

thanks,

Mimi