Re: [PATCH v2 1/1] lkdtm/stackleak: Make the test more verbose

From: Kees Cook
Date: Mon Jan 27 2020 - 18:15:11 EST


On Wed, Jan 22, 2020 at 02:58:44PM +0300, Alexander Popov wrote:
> On 03.01.2020 02:49, Alexander Popov wrote:
> > Make the stack erasing test more verbose about the errors that it
> > can detect.
> >
> > Signed-off-by: Alexander Popov <alex.popov@xxxxxxxxx>
> > ---
> > drivers/misc/lkdtm/stackleak.c | 25 +++++++++++++++++--------
> > 1 file changed, 17 insertions(+), 8 deletions(-)
>
> Hello!
>
> Pinging about this version of the patch.
>
> Kees, it uses dump_stack() instead of BUG(), as we negotiated.

Yup, this is in my queue -- I've just gotten back from travelling and
will get to it shortly. :)

Greg, feel free to take this directly if you want, too.

-Kees

--
Kees Cook