Re: [RFC PATCH] tracing/kprobe: trace_kprobe_disabled_finished can be static

From: Masami Hiramatsu
Date: Tue Jan 28 2020 - 10:02:29 EST


On Mon, 27 Jan 2020 23:02:43 +0800
kbuild test robot <lkp@xxxxxxxxx> wrote:

>
> Fixes: 3c794bf25a2b ("tracing/kprobe: Use call_rcu to defer freeing event_file_link")
> Signed-off-by: kbuild test robot <lkp@xxxxxxxxx>
> ---
> trace_kprobe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
> index 1a5882bb77471..fba738aa458af 100644
> --- a/kernel/trace/trace_kprobe.c
> +++ b/kernel/trace/trace_kprobe.c
> @@ -328,7 +328,7 @@ static inline int __enable_trace_kprobe(struct trace_kprobe *tk)
> return ret;
> }
>
> -atomic_t trace_kprobe_disabled_finished;
> +static atomic_t trace_kprobe_disabled_finished;
>
> static void trace_kprobe_disabled_handlers_finish(void)
> {

Oops, right. I forgot the static. I'll update it.

Thanks,

--
Masami Hiramatsu <mhiramat@xxxxxxxxxx>