Re: [PATCH v2 1/1] lkdtm/stackleak: Make the test more verbose

[Kees Cook]

On Tue, Jan 28, 2020 at 08:50:50AM +0100, Greg Kroah-Hartman wrote:
> On Mon, Jan 27, 2020 at 03:15:08PM -0800, Kees Cook wrote:
> > On Wed, Jan 22, 2020 at 02:58:44PM +0300, Alexander Popov wrote:
> > > On 03.01.2020 02:49, Alexander Popov wrote:
> > > > Make the stack erasing test more verbose about the errors that it
> > > > can detect.
> > > > 
> > > > Signed-off-by: Alexander Popov <alex.popov@xxxxxxxxx>
> > > > ---
> > > >  drivers/misc/lkdtm/stackleak.c | 25 +++++++++++++++++--------
> > > >  1 file changed, 17 insertions(+), 8 deletions(-)
> > > 
> > > Hello!
> > > 
> > > Pinging about this version of the patch.
> > > 
> > > Kees, it uses dump_stack() instead of BUG(), as we negotiated.
> > 
> > Yup, this is in my queue -- I've just gotten back from travelling and
> > will get to it shortly. :)
> > 
> > Greg, feel free to take this directly if you want, too.
> 
> If I were to take it, it would have to wait until after 5.6-rc1, sorry.

Well, it has to go via drivers/misc anyway, so I think timing is no
different. I would consider this a feature patch, not a bug fix, too.

-- 
Kees Cook