Re: [PATCH v3 1/5] console: Don't perform test for CON_BRL flag

[Petr Mladek]

On Mon 2020-01-27 13:47:15, Andy Shevchenko wrote:
> We don't call braille_register_console() without CON_BRL flag set.
> And the _braille_unregister_console() already tests for console to have
> CON_BRL flag. No need to repeat this in braille_unregister_console().
> 
> Drop the repetitive checks from Braille console driver.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

I wish the braille console support was added a cleaner way.

I am always confused what is the generic code and what is specific
for the only supported VisioBraille console. And braile()
functions called from _braile() wrappers just add to the confusion.

Anyway, I am fine with this patch.

Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>

Best Regards,
Petr