Re: [PATCH] mm/page_counter: fix various data races

From: Tetsuo Handa
Date: Wed Jan 29 2020 - 08:09:44 EST


On 2020/01/29 21:25, Qian Cai wrote:
>
>
>> On Jan 29, 2020, at 7:13 AM, Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx> wrote:
>>
>> By the way, can READ_ONCE()/WRITE_ONCE() really solve this warning?
>> The link above says read/write on the same location ( mm/page_counter.c:129 ).
>> I don't know how READ_ONCE()/WRITE_ONCE() can solve the race.
>
> That looks like a different one where it complains about c->failcnt++. Iâll send a separate patch for that.
>

Ah, then this patch is meant for mm/page_counter.c:138 versus page_counter.c:139 race which was
closed as invalid at https://syzkaller.appspot.com/bug?id=871391ec080746185a2dd437c54d75fcd1ef0ef8 .