Re: [PATCH 13/28] ata: move ata_do_link_spd_horkage() to libata-core-sata.c

From: Christoph Hellwig
Date: Wed Jan 29 2020 - 12:28:15 EST

Next message: Christoph Hellwig: "Re: [PATCH 14/28] ata: move ata_dev_config_ncq*() to libata-core-sata.c"
Previous message: Rob Herring: "Re: [PATCH v6 2/2] dt-bindings: hwmon: (adt7475) Added missing adt7475 documentation"
In reply to: Bartlomiej Zolnierkiewicz: "[PATCH 13/28] ata: move ata_do_link_spd_horkage() to libata-core-sata.c"
Next in thread: Bartlomiej Zolnierkiewicz: "[PATCH 03/28] ata: make SATA_PMP option selectable only if any SATA host driver is enabled"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, Jan 28, 2020 at 02:33:28PM +0100, Bartlomiej Zolnierkiewicz wrote:
> * move ata_do_link_spd_horkage() to libata-core-sata.c
>
> * add static inline for CONFIG_SATA_HOST=n case

Wouldn't it make more sense to stub out sata_scr_valid for the !SATA
case and just let the compiler optimize the function away now that it
can't be called in that case?

Next message: Christoph Hellwig: "Re: [PATCH 14/28] ata: move ata_dev_config_ncq*() to libata-core-sata.c"
Previous message: Rob Herring: "Re: [PATCH v6 2/2] dt-bindings: hwmon: (adt7475) Added missing adt7475 documentation"
In reply to: Bartlomiej Zolnierkiewicz: "[PATCH 13/28] ata: move ata_do_link_spd_horkage() to libata-core-sata.c"
Next in thread: Bartlomiej Zolnierkiewicz: "[PATCH 03/28] ata: make SATA_PMP option selectable only if any SATA host driver is enabled"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]