Re: [GIT PULL] USB/Thunderbolt/PHY patches for 5.6-rc1
From: Krzysztof Kozlowski
Date: Wed Jan 29 2020 - 13:27:33 EST
On Wed, Jan 29, 2020 at 10:23:54AM -0800, Linus Torvalds wrote:
> On Wed, Jan 29, 2020 at 10:20 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> >
> > The I2C fix for this is in Wolfram's tree already:
>
> It was never an i2c error.
>
> It was an error in that commit that made a change that introduced a new warning.
>
> It is *not* acceptable to break things and say "somebody else will fix
> it up later".
>
> If it's broken in the PHY tree, then the PHY tree is broken. It's that simple.
>
> We don't enable compile testing that causes warnings.
I never said it was an I2C error but only that the fix is there already.
The error in first place was mine because I did not spot the
bisectability problem when preparing the entire set of
compile-testing patches.
Best regards,
Krzysztof