Re: [PATCH] KVM: x86: Fix perfctr WRMSR for running counters

From: Eric Hankland
Date: Wed Jan 29 2020 - 20:10:15 EST


Sorry - I forgot to switch to plain text mode on my first reply.

> I think this best written as it was before commit 2924b52117:
>
> if (!msr_info->host_initiated)
> data = (s64)(s32)data;
> pmc->counter += data - pmc_read_counter(pmc);
Sounds good to me.

> Do you have a testcase?
I added a testcase to kvm-unit-tests/x86/pmu.c that fails without this
patch and passes with it.
Should I send out that patch now?