Re: [PATCH V5] firmware: arm_scmi: Make scmi core independent of the transport type

[Peter Hilber]

On 28.01.20 18:35, Sudeep Holla wrote:
> Otherwise looks good. Since we are not adding module support, I am fine
> even if we have to make changes to transport ops bit later if required
> and realised when adding new transport. Let us see if Peter has any major
> objections.

I have no objections. Looks good. One remark:

> +struct scmi_transport_ops {
> +     bool (*chan_available)(struct device *dev, int idx);
> +     int (*chan_setup)(struct scmi_chan_info *cinfo, struct device *dev, bool tx);
> +     int (*chan_free)(int id, void *p, void *data);
> +     int (*send_message)(struct scmi_chan_info *cinfo, struct scmi_xfer *xfer);
> +     void (*mark_txdone)(struct scmi_chan_info *cinfo, int ret);
> +     void (*fetch_response)(struct scmi_chan_info *cinfo, struct scmi_xfer *xfer);
> +     bool (*poll_done)(struct scmi_chan_info *cinfo, struct scmi_xfer *xfer);
> +};

Maybe the mark_txdone, fetch_response, and poll_done ops should also get
a `u32 msg_hdr' parameter? I thought it could be required in case of
concurrent xfers, or maybe I don't understand the imposed concurrency
limitations properly.

Best regards,

Peter

Please mind our privacy notice<https://www.opensynergy.com/datenschutzerklaerung/privacy-notice-for-business-partners-pursuant-to-article-13-of-the-general-data-protection-regulation-gdpr/> pursuant to Art. 13 GDPR. // Unsere Hinweise zum Datenschutz gem. Art. 13 DSGVO finden Sie hier.<https://www.opensynergy.com/de/datenschutzerklaerung/datenschutzhinweise-fuer-geschaeftspartner-gem-art-13-dsgvo/>


[tech_days_munchen]

OpenSynergy TechDay MÃnchen

am 11. Februar 2020, ab 12:00Uhr, im Studio Balan, Moosacherstr. 86.

Anmeldung bitte hier<mailto:sabine.mutumba@xxxxxxxxxxxxxxx>