Re: [PATCH 03/17] follow_automount(): get rid of dead^Wstillborn code

From: Christian Brauner
Date: Thu Jan 30 2020 - 09:38:57 EST


On Sun, Jan 19, 2020 at 03:17:15AM +0000, Al Viro wrote:
> From: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
>
> 1) no instances of ->d_automount() have ever made use of the "return
> ERR_PTR(-EISDIR) if you don't feel like mounting anything" - that's
> a rudiment of plans that got superseded before the thing went into
> the tree. Despite the comment in follow_automount(), autofs has
> never done that.
>
> 2) if there's no ->d_automount() in dentry_operations, filesystems
> should not set DCACHE_NEED_AUTOMOUNT in the first place. None have
> ever done so...
>
> Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>

I can't speak to 1) but code seems correct:
Acked-by: Christian Brauner <christian.brauner@xxxxxxxxxx>