Re: [PATCH] dmaengine: idxd: fix boolconv.cocci warnings

From: Dave Jiang
Date: Thu Jan 30 2020 - 11:13:06 EST




On 1/30/20 7:44 AM, Julia Lawall wrote:
From: kbuild test robot <lkp@xxxxxxxxx>

Remove unneeded conversion to bool

Generated by: scripts/coccinelle/misc/boolconv.cocci

CC: Dave Jiang <dave.jiang@xxxxxxxxx>
Signed-off-by: kbuild test robot <lkp@xxxxxxxxx>
Signed-off-by: Julia Lawall <julia.lawall@xxxxxxxx>

Acked-by: Dave Jiang <dave.jiang@xxxxxxxxx>

---

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 39bed42de2e7d74686a2d5a45638d6a5d7e7d473
commit: 42d279f9137ab7d5503836baec2739284b278d8f dmaengine: idxd: add char driver to expose submission portal to userland
:::::: branch date: 11 hours ago
:::::: commit date: 6 days ago

Please take the patch only if it's a positive warning. Thanks!

sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/dma/idxd/sysfs.c
+++ b/drivers/dma/idxd/sysfs.c
@@ -66,7 +66,7 @@ static inline bool is_idxd_wq_dmaengine(

static inline bool is_idxd_wq_cdev(struct idxd_wq *wq)
{
- return wq->type == IDXD_WQT_USER ? true : false;
+ return wq->type == IDXD_WQT_USER;
}

static int idxd_config_bus_match(struct device *dev,