Re: Re: Re: [RFC PATCH v1 5/5] arm64: tegra: Add Tegra VI CSI suppport in device tree

[Thierry Reding]

On Thu, Jan 30, 2020 at 09:18:50AM -0800, Sowjanya Komatineni wrote:
> 
> On 1/30/20 4:36 AM, Thierry Reding wrote:
> > On Wed, Jan 29, 2020 at 08:22:48AM -0800, Sowjanya Komatineni wrote:
> > > On 1/29/20 1:46 AM, Thierry Reding wrote:
> > > > On Tue, Jan 28, 2020 at 10:23:21AM -0800, Sowjanya Komatineni wrote:
> > > > > Tegra210 contains VI controller for video input capture from MIPI
> > > > > CSI camera sensors and also supports built-in test pattern generator.
> > > > > 
> > > > > CSI ports can be one-to-one mapped to VI channels for capturing from
> > > > > an external sensor or from built-in test pattern generator.
> > > > > 
> > > > > This patch adds support for VI and CSI and enables them in Tegra210
> > > > > device tree.
> > > > > 
> > > > > Signed-off-by: Sowjanya Komatineni <skomatineni@xxxxxxxxxx>
> > > > > ---
> > > > >    arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi |  8 +++++++
> > > > >    arch/arm64/boot/dts/nvidia/tegra210.dtsi       | 31 +++++++++++++++++++++++++-
> > > > >    2 files changed, 38 insertions(+), 1 deletion(-)
> > > > > 
> > > > > diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
> > > > > index b0095072bc28..ec1b3033fa03 100644
> > > > > --- a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
> > > > > +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
> > > > > @@ -10,6 +10,14 @@
> > > > >    			status = "okay";
> > > > >    		};
> > > > > +		vi@54080000 {
> > > > > +			status = "okay";
> > > > > +		};
> > > > > +
> > > > > +		csi@0x54080838 {
> > > > > +			status = "okay";
> > > > > +		};
> > > > > +
> > > > >    		sor@54580000 {
> > > > >    			status = "okay";
> > > > > diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> > > > > index 48c63256ba7f..c6107ec03ad1 100644
> > > > > --- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> > > > > +++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> > > > > @@ -136,9 +136,38 @@
> > > > >    		vi@54080000 {
> > > > >    			compatible = "nvidia,tegra210-vi";
> > > > > -			reg = <0x0 0x54080000 0x0 0x00040000>;
> > > > > +			reg = <0x0 0x54080000 0x0 0x808>;
> > > > >    			interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
> > > > >    			status = "disabled";
> > > > > +			assigned-clocks = <&tegra_car TEGRA210_CLK_VI>;
> > > > > +			assigned-clock-parents = <&tegra_car TEGRA210_CLK_PLL_C4_OUT0>;
> > > > > +
> > > > > +			clocks = <&tegra_car TEGRA210_CLK_VI>;
> > > > > +			clock-names = "vi";
> > > > > +			resets = <&tegra_car 20>;
> > > > > +			reset-names = "vi";
> > > > > +		};
> > > > > +
> > > > > +		csi@0x54080838 {
> > > > > +			compatible = "nvidia,tegra210-csi";
> > > > > +			reg = <0x0 0x54080838 0x0 0x2000>;
> > > > > +			status = "disabled";
> > > > > +			assigned-clocks = <&tegra_car TEGRA210_CLK_CILAB>,
> > > > > +					  <&tegra_car TEGRA210_CLK_CILCD>,
> > > > > +					  <&tegra_car TEGRA210_CLK_CILE>;
> > > > > +			assigned-clock-parents = <&tegra_car TEGRA210_CLK_PLL_P>,
> > > > > +						 <&tegra_car TEGRA210_CLK_PLL_P>,
> > > > > +						 <&tegra_car TEGRA210_CLK_PLL_P>;
> > > > > +			assigned-clock-rates = <102000000>,
> > > > > +					       <102000000>,
> > > > > +					       <102000000>;
> > > > > +
> > > > > +			clocks = <&tegra_car TEGRA210_CLK_CSI>,
> > > > > +				 <&tegra_car TEGRA210_CLK_CILAB>,
> > > > > +				 <&tegra_car TEGRA210_CLK_CILCD>,
> > > > > +				 <&tegra_car TEGRA210_CLK_CILE>;
> > > > > +			clock-names = "csi", "cilab", "cilcd", "cile";
> > > > > +
> > > > >    		};
> > > > Can this be a child of the vi node? Looking at the register ranges it
> > > > seems like these are actually a single IP block. If they have separate
> > > > blocks with clearly separate functionality, then it makes sense to have
> > > > CSI be a child node of VI, though it may also be okay to merge both and
> > > > have a single node with the driver doing all of the differentiation
> > > > between what's VI and what's CSI.
> > > > 
> > > > Looking at later chips, the split between VI and CSI is more explicit,
> > > > so having the split in DT for Tegra210 may make sense for consistency.
> > > > 
> > > > I know we've discussed this before, but for some reason I keep coming
> > > > back to this. I'll go through the other patches to see if I can get a
> > > > clearer picture of how this could all work together.
> > > > 
> > > > Thierry
> > > We can keep it separate as we discussed.
> > > 
> > > But as Tegra186 onwards, CSI is separate device to be all cosistent I kept
> > > CSI as separate node for Tegra210 as well.
> >  From our discussion, my understanding was that CSI would be a separate
> > device, but it would still be a subdevice of VI. The address offset of
> > the CSI registers not being aligned to a power of two is a strong
> > indication that this is really all part of the same block.
> 
> Yes our earlier discussion is to have CSI as subdevice.
> 
> Later looking into T186 and later NVCSI is totally separate so it will be
> separate device and to have driver common moved Tegra210 CSI also as
> separate device instead of having it as subdevice of VI.
> 
> Earlier when we discussed at that time I am using TPG also from device
> graphs but not moved to hard media links inside driver for TPG.
> 
> For this we need CSI to be available prior to VI.

Why is that? Does creating the hard media links need access to a struct
device? What if we created that device in the VI driver without any
reliance on DT? Shouldn't that also work? I have a hard time imagining
that there aren't other devices like this where we don't necessarily
have separate devices for these links.

> If we add CSI as subdevice to VI, CSI will not be available by the time
> VI init happens.

The CSI subdevice should be registered as part of the VI driver's probe,
right? That's typically where you'd call of_platform_populate(). Could
we not set up the hard media links in the ->init() callbacks for the
host1x clients? Those are called after all of the devices have been
probed, so the CSI device should be available at that time.

> Currently host1x subdevices listed has CSI before VI and CSI init happens
> earlier so by the time VI init happens CSI is available to do media links
> b/w VI video entity and CSI subdevice entity.

Okay, I understand how this would be a convenient solution. However, the
device tree is a hardware description, so we need to ignore what we know
about the operating system infrastructure that we want to use when
writing the device tree bindings (and the device tree content) in order
to make sure the same binding will work on a different operating system
which may have a completely different infrastructure (or none at all).

> Also having CSI as separate subdevice (not as subdevice to VI) for T210 will
> be consistent with T186 and later.

Again, I see how that's convenient. But the main difference between
Tegra210 and Tegra186 is that on the former, the CSI is merged with VI,
whereas on the latter the CSI is a completely separate hardware block.

Since device tree describes the hardware, that difference should be
apparent in the device tree. I initially thought as well that it would
be advantageous if both had the same representation, but I do realize
now that this has a significant impact on the device tree, and it
violates the basic principles we base device tree binding design on.

Thierry

Attachment: signature.asc
Description: PGP signature