Re: [PATCH] usb: core: urb: change a dev_WARN() to dev_err() for syzbot

[Steven Rostedt]

On Fri, 31 Jan 2020 12:19:39 +0100
Dmitry Vyukov <dvyukov@xxxxxxxxxx> wrote:

> +Eric, Steve, who got these WARNING-not-a-kernel-bug reports recently too

I've been trying to convert all WARN_ON() in my code to be only
triggered if something happens where I don't expect it to happen, and
there's either a bug in the code, or I missed something in the design
of the code. That is, if a WARN_ON() triggers, it means I need to have
a good look at the code to figure out why.

I like the idea of a NOTICE() that can be used for hardware bugs or bad
user input. Something to say, "the kernel code is fine, but we received
something we did not expect", which to me is different than a bug in
the kernel. Although, it could lead to finding a bug.

-- Steve