Re: [PATCH RFC locktorture] Print ratio of acquisitions, not failures

From: Davidlohr Bueso
Date: Fri Jan 31 2020 - 12:51:11 EST


On Thu, 23 Jan 2020, Paul E. McKenney wrote:

The __torture_print_stats() function in locktorture.c carefully
initializes local variable "min" to statp[0].n_lock_acquired, but
then compares it to statp[i].n_lock_fail. Given that the .n_lock_fail
field should normally be zero, and given the initialization, it seems
reasonable to display the maximum and minimum number acquisitions
instead of miscomputing the maximum and minimum number of failures.
This commit therefore switches from failures to acquisitions.

This makes sense, thanks!


Reported-by: Will Deacon <will@xxxxxxxxxx>
Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxx>
Cc: Davidlohr Bueso <dave@xxxxxxxxxxxx>
Cc: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>

Acked-by: Davidlohr Bueso <dbueso@xxxxxxx>