Re: [PATCH V2] x86/apic/msi: Plug non-maskable MSI affinity race

[Thomas Gleixner]

Evan Green <evgreen@xxxxxxxxxxxx> writes:
> On Fri, Jan 31, 2020 at 6:27 AM Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>> #1 is uninteresting and has no unintended side effects. #2 and #3 might
>> expose issues in device driver interrupt handlers which are not prepared to
>> handle a spurious interrupt correctly. This not a regression, it's just
>> exposing something which was already broken as spurious interrupts can
>> happen for a lot of reasons and all driver handlers need to be able to deal
>> with them.
>>
>> Reported-by: Evan Green <evgreen@xxxxxxxxxxxx>
>> Debugged-by: Evan Green <evgreen@xxxxxxxxxxxx>                                                                                        Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>
> Heh, thanks for the credit.

Thanks for the detective work and the persistance to convince me!

> Something weird happened on this line with your signoff, though.

Yeah. No idea how I fatfingered that.

> I've been running this on my system for a few hours with no issues
> (normal repro in <1 minute). So,
>
> Tested-by: Evan Green <evgreen@xxxxxxxxxxxx>

Thanks for confirmation!

       tglx