Re: [PATCH 06/12] dt-bindings: arm: bcm: Convert BCM21664 to YAML

[Maxime Ripard]

On Sun, Feb 02, 2020 at 01:18:21PM -0800, Florian Fainelli wrote:
> Update the Broadcom BCM21664 SoC binding document for boards/SoCs to use
> YAML. Verified with dt_binding_check and dtbs_check.
>
> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> ---
>  .../bindings/arm/bcm/brcm,bcm21664.txt        | 15 ------------
>  .../bindings/arm/bcm/brcm,bcm21664.yaml       | 23 +++++++++++++++++++
>  2 files changed, 23 insertions(+), 15 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/arm/bcm/brcm,bcm21664.txt
>  create mode 100644 Documentation/devicetree/bindings/arm/bcm/brcm,bcm21664.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm21664.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm21664.txt
> deleted file mode 100644
> index e0774255e1a6..000000000000
> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm21664.txt
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -Broadcom BCM21664 device tree bindings
> ---------------------------------------
> -
> -This document describes the device tree bindings for boards with the BCM21664
> -SoC.
> -
> -Required root node property:
> -  - compatible: brcm,bcm21664
> -
> -Example:
> -	/ {
> -		model = "BCM21664 SoC";
> -		compatible = "brcm,bcm21664";
> -		[...]
> -	}
> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm21664.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm21664.yaml
> new file mode 100644
> index 000000000000..8a38a6b68f60
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm21664.yaml
> @@ -0,0 +1,23 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/bcm/brcm,bcm21664.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom BCM21664 device tree bindings
> +
> +maintainers:
> +  - Florian Fainelli <f.fainelli@xxxxxxxxx>
> +
> +properties:
> +  $nodename:
> +    const: '/'
> +  compatible:
> +    oneOf:
> +      - description: BCM21664 based boards
> +        items:
> +          - enum:
> +              - brcm,bcm21664-garnet
> +          - const: brcm,bcm21664

Do you really need the oneOf here?

Maxime