Re: [PATCH 1/3] dt-bindings: regulator: add document bindings for mp5416

[Rob Herring]

On Wed, Jan 22, 2020 at 02:59:56PM +0100, Saravanan Sekar wrote:
> Add device tree binding information for mp5416 regulator driver.
> 
> Signed-off-by: Saravanan Sekar <sravanhome@xxxxxxxxx>
> ---
>  .../bindings/regulator/mps,mp5416.yaml        | 78 +++++++++++++++++++
>  1 file changed, 78 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/mps,mp5416.yaml
> 
> diff --git a/Documentation/devicetree/bindings/regulator/mps,mp5416.yaml b/Documentation/devicetree/bindings/regulator/mps,mp5416.yaml
> new file mode 100644
> index 000000000000..702508e4267f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/mps,mp5416.yaml
> @@ -0,0 +1,78 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/mps,mp5416.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Monolithic Power System MP5416 PMIC
> +
> +maintainers:
> +  - Saravanan Sekar <sravanhome@xxxxxxxxx>
> +
> +properties:
> +  $nodename:
> +    pattern: "pmic@[0-9a-f]{1,2}"

Needs a ^ and $.

> +  compatible:
> +    enum:
> +      - mps,mp5416
> +
> +  reg:
> +    maxItems: 1
> +
> +  regulators:
> +    type: object
> +    allOf:
> +      - $ref: regulator.yaml#

Does this node contain regulator properties?

> +    description: |
> +      list of regulators provided by this controller, must be named
> +      after their hardware counterparts BUCK[1-4] and LDO[1-4]
> +
> +    patternProperties:
> +      "^buck[1-4]$":
> +        $ref: "regulator.yaml#"

Must be under 'allOf' or other constraints are ignored.

> +        type: object
> +
> +      "^ldo[1-4]$":
> +        $ref: "regulator.yaml#"
> +        type: object
> +
> +    additionalProperties: false
> +  additionalProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - regulators
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        pmic@69 {
> +          compatible = "mps,mp5416";
> +          reg = <0x69>;
> +
> +          regulators {
> +
> +            buck1 {
> +             regulator-name = "buck1";
> +             regulator-min-microvolt = <600000>;
> +             regulator-max-microvolt = <2187500>;
> +             regulator-min-microamp  = <3800000>;
> +             regulator-max-microamp  = <6800000>;
> +             regulator-boot-on;
> +            };
> +
> +            ldo2 {
> +             regulator-name = "ldo2";
> +             regulator-min-microvolt = <800000>;
> +             regulator-max-microvolt = <3975000>;
> +            };
> +         };
> +       };
> +     };
> +...
> -- 
> 2.17.1
>