Re: [PATCH v1 0/7] ACPI support for xgmac_mdio and dpaa2-mac drivers.

[Florian Fainelli]

On 1/31/20 7:34 AM, Calvin Johnson wrote:
> From: Calvin Johnson <calvin.johnson@xxxxxxxxxxx>
> 
> This patch series provides ACPI support for xgmac_mdio and dpaa2-mac
> driver. Most of the DT APIs are replaced with fwnode APIs to handle
> both DT and ACPI nodes.
> 
> Old patch by Marcin Wojtas: (mdio_bus: Introduce fwnode MDIO helpers),
> is reused in this series to get some fwnode mdio helper APIs.

Andrew's comment on your first patch is a good summary of what this
patch series does, instead of consolidating the existing code and making
it less of_* centric and more firmware agnostic, this duplicates the
existing infrastructure almost line for line to create a fwnode specific
implementation. The preference would be for you to move away from that
and use device_* properties as much as possible while making the code
capable of handling all firmware implementations.

Can you also show a few DSDT for the devices that you are working so we
can a feeling of how you represented the various properties and
parent/child devices dependencies?

> 
> 
> Calvin Johnson (6):
>   mdio_bus: modify fwnode phy related functions
>   net/fsl: add ACPI support for mdio bus
>   device property: fwnode_get_phy_mode: Change API to solve int/unit
>     warnings
>   device property: Introduce fwnode_phy_is_fixed_link()
>   net: phylink: Introduce phylink_fwnode_phy_connect()
>   dpaa2-eth: Add ACPI support for DPAA2 MAC driver
> 
> Marcin Wojtas (1):
>   mdio_bus: Introduce fwnode MDIO helpers
> 
>  drivers/base/property.c                       |  43 ++-
>  .../net/ethernet/freescale/dpaa2/dpaa2-mac.c  |  78 ++++--
>  drivers/net/ethernet/freescale/xgmac_mdio.c   |  63 +++--
>  .../net/ethernet/marvell/mvpp2/mvpp2_main.c   |   7 +-
>  drivers/net/phy/mdio_bus.c                    | 244 ++++++++++++++++++
>  drivers/net/phy/phylink.c                     |  64 +++++
>  include/linux/mdio.h                          |   3 +
>  include/linux/phylink.h                       |   2 +
>  include/linux/property.h                      |   5 +-
>  9 files changed, 450 insertions(+), 59 deletions(-)
> 


-- 
Florian