Re: [PATCH v4 6/7] drivers: thermal: tsens: kernel-doc fixup

[Bjorn Andersson]

On Thu 30 Jan 05:27 PST 2020, Amit Kucheria wrote:

> Document ul_lock, threshold and control structure members and make
> the following kernel-doc invocation happy:
> 
> $ scripts/kernel-doc -v -none drivers/thermal/qcom/*
> 
> drivers/thermal/qcom/qcom-spmi-temp-alarm.c:105: info: Scanning doc for qpnp_tm_get_temp_stage
> drivers/thermal/qcom/tsens-common.c:18: info: Scanning doc for struct tsens_irq_data
> drivers/thermal/qcom/tsens-common.c:130: info: Scanning doc for tsens_hw_to_mC
> drivers/thermal/qcom/tsens-common.c:163: info: Scanning doc for tsens_mC_to_hw
> drivers/thermal/qcom/tsens-common.c:245: info: Scanning doc for tsens_set_interrupt
> drivers/thermal/qcom/tsens-common.c:268: info: Scanning doc for tsens_threshold_violated
> drivers/thermal/qcom/tsens-common.c:362: info: Scanning doc for tsens_critical_irq_thread
> drivers/thermal/qcom/tsens-common.c:438: info: Scanning doc for tsens_irq_thread
> drivers/thermal/qcom/tsens.h:41: info: Scanning doc for struct tsens_sensor
> drivers/thermal/qcom/tsens.h:59: info: Scanning doc for struct tsens_ops
> drivers/thermal/qcom/tsens.h:494: info: Scanning doc for struct tsens_features
> drivers/thermal/qcom/tsens.h:513: info: Scanning doc for struct tsens_plat_data
> drivers/thermal/qcom/tsens.h:529: info: Scanning doc for struct tsens_context
> 

Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>

> Signed-off-by: Amit Kucheria <amit.kucheria@xxxxxxxxxx>
> ---
>  drivers/thermal/qcom/tsens.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/thermal/qcom/tsens.h b/drivers/thermal/qcom/tsens.h
> index cf0511a947d4..dd163b27add4 100644
> --- a/drivers/thermal/qcom/tsens.h
> +++ b/drivers/thermal/qcom/tsens.h
> @@ -526,6 +526,8 @@ struct tsens_plat_data {
>  
>  /**
>   * struct tsens_context - Registers to be saved/restored across a context loss
> + * @threshold: Threshold register value
> + * @control: Control register value
>   */
>  struct tsens_context {
>  	int	threshold;
> @@ -540,6 +542,7 @@ struct tsens_context {
>   * @srot_map: pointer to SROT register address space
>   * @tm_offset: deal with old device trees that don't address TM and SROT
>   *             address space separately
> + * @ul_lock: lock while processing upper/lower threshold interrupts
>   * @crit_lock: lock while processing critical threshold interrupts
>   * @rf: array of regmap_fields used to store value of the field
>   * @ctx: registers to be saved and restored during suspend/resume
> -- 
> 2.20.1
>