Re: [PATCH v4 7/7] drivers: thermal: tsens: Remove unnecessary irq flag

From: Bjorn Andersson
Date: Mon Feb 03 2020 - 13:44:13 EST


On Thu 30 Jan 05:27 PST 2020, Amit Kucheria wrote:

> IRQF_TRIGGER_HIGH is already specified through devicetree interrupts
> property. Remove it from code.
>

Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>

> Signed-off-by: Amit Kucheria <amit.kucheria@xxxxxxxxxx>
> ---
> drivers/thermal/qcom/tsens.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
> index 5b003d598234..9ee00c67144c 100644
> --- a/drivers/thermal/qcom/tsens.c
> +++ b/drivers/thermal/qcom/tsens.c
> @@ -118,7 +118,7 @@ static int tsens_register(struct tsens_priv *priv)
>
> ret = devm_request_threaded_irq(&pdev->dev, irq,
> NULL, tsens_irq_thread,
> - IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
> + IRQF_ONESHOT,
> dev_name(&pdev->dev), priv);
> if (ret) {
> dev_err(&pdev->dev, "%s: failed to get irq\n", __func__);
> --
> 2.20.1
>