Re: [PATCH] sched/core: sched_tick_remote: Remove duplicate assignment

[Scott Wood]

On Tue, 2020-02-04 at 09:27 -0500, Phil Auld wrote:
> Hi Scott,
> 
> On Mon, Feb 03, 2020 at 07:35:58PM -0500 Scott Wood wrote:
> > A redundant "curr = rq->curr" was added; remove it.
> > 
> > Fixes: ebc0f83c78a2 ("timers/nohz: Update NOHZ load in remote tick")
> > Signed-off-by: Scott Wood <swood@xxxxxxxxxx>
> > ---
> >  kernel/sched/core.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> > index 45f79bcc3146..377ec26e9159 100644
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -3683,7 +3683,6 @@ static void sched_tick_remote(struct work_struct
> > *work)
> >  	if (cpu_is_offline(cpu))
> >  		goto out_unlock;
> >  
> > -	curr = rq->curr;
> >  	update_rq_clock(rq);
> >  
> >  	if (!is_idle_task(curr)) {
> > -- 
> > 1.8.3.1
> > 
> 
> Reviewed-by: Phil Auld <pauld@xxxxxxxxxx>
> 
> Out of curiosity, why remove this one and not the one right before the 
> cpu_is_offline check?

This was the one that was recently added by mistake.

-Scott