Re: [PATCH 2/3] i2c: qcom-geni: Grow a dev pointer to simplify code

[Brendan Higgins]

On Tue, Feb 4, 2020 at 11:32 AM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote:
>
> Some lines are long here. Use a struct dev pointer to shorten lines and
> simplify code. The clk_get() call can fail because of EPROBE_DEFER
> problems too, so just remove the error print message because it isn't
> useful.
>
> Cc: Girish Mahadevan <girishm@xxxxxxxxxxxxxx>
> Cc: Dilip Kota <dkota@xxxxxxxxxxxxxx>
> Cc: Alok Chauhan <alokc@xxxxxxxxxxxxxx>
> Cc: Douglas Anderson <dianders@xxxxxxxxxxxx>
> Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>

I personally am indifferent to &pdev->dev vs. just dev, but not
printing an error in the case of a defer is a definite improvement.

Reviewed-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>