Re: [PATCH v2] ASoC: wcd934x: Add missing COMMON_CLK dependency

[Stephen Rothwell]

Hi Geert,

On Tue, 4 Feb 2020 14:21:01 +0100 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> On Tue, Feb 4, 2020 at 12:14 PM Srinivas Kandagatla
> <srinivas.kandagatla@xxxxxxxxxx> wrote:
> > Looks like some platforms are not yet using COMMON CLK.
> >
> > PowerPC allyesconfig failed with below error in next
> >
> > ld: sound/soc/codecs/wcd934x.o:(.toc+0x0):
> >          undefined reference to `of_clk_src_simple_get'
> > ld: sound/soc/codecs/wcd934x.o: in function `.wcd934x_codec_probe':
> > wcd934x.c:(.text.wcd934x_codec_probe+0x3d4):
> >          undefined reference to `.__clk_get_name'
> > ld: wcd934x.c:(.text.wcd934x_codec_probe+0x438):
> >          undefined reference to `.clk_hw_register'
> > ld: wcd934x.c:(.text.wcd934x_codec_probe+0x474):
> >          undefined reference to `.of_clk_add_provider'
> >
> > Add the missing COMMON_CLK dependency to fix this errors.
> >
> > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>  
> 
> Thanks for your patch!
> 
> But did this change really fix your PowerPC allyesconfig build?

It does not :-(

> SND_SOC_ALL_CODECS will still select it...
> 
> Fix sent.

I have applied that patch to linux-next today.

-- 
Cheers,
Stephen Rothwell

Attachment: pgpwoy9I7QtWa.pgp
Description: OpenPGP digital signature