Re: [PATCH] mtd: nand: Add comment about Kioxia ID

[Miquel Raynal]

Hi Yoshio,

Yoshio Furuyama <ytc-mb-yfuruyama7@xxxxxxxxxx> wrote on Tue, 4 Feb 2020
19:30:04 +0900:

> Dear MiquÃl,
> 
> 
> On 2020/02/04 17:52, Miquel Raynal wrote:
> > Hi Yoshio,
> >
> > Yoshio Furuyama <ytc-mb-yfuruyama7@xxxxxxxxxx> wrote on Tue,  4 Feb
> > 2020 11:26:03 +0900:
> >  
> >> Add a comment above NAND_MFR_TOSHIBA and SPINAND_MFR_TOSHIBA definitions
> >> that Toshiba and Kioxia ID are the same.
> >>
> >> Signed-off-by: Yoshio Furuyama <ytc-mb-yfuruyama7@xxxxxxxxxx>
> >> ---
> >>   drivers/mtd/nand/raw/internals.h | 1 +
> >>   drivers/mtd/nand/spi/toshiba.c   | 1 +
> >>   2 files changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/mtd/nand/raw/internals.h b/drivers/mtd/nand/raw/internals.h
> >> index cba6fe7..2918376b 100644
> >> --- a/drivers/mtd/nand/raw/internals.h
> >> +++ b/drivers/mtd/nand/raw/internals.h
> >> @@ -30,6 +30,7 @@
> >>   #define NAND_MFR_SAMSUNG	0xec
> >>   #define NAND_MFR_SANDISK	0x45
> >>   #define NAND_MFR_STMICRO	0x20
> >> +/* Toshiba and Kioxia ID are the same. */
> >>   #define NAND_MFR_TOSHIBA	0x98
> >>   #define NAND_MFR_WINBOND	0xef  
> >>   >> diff --git a/drivers/mtd/nand/spi/toshiba.c b/drivers/mtd/nand/spi/toshiba.c  
> >> index 0db5ee4..a92ecc8 100644
> >> --- a/drivers/mtd/nand/spi/toshiba.c
> >> +++ b/drivers/mtd/nand/spi/toshiba.c
> >> @@ -10,6 +10,7 @@
> >>   #include <linux/kernel.h>
> >>   #include <linux/mtd/spinand.h>  
> >>   >> +/* Toshiba and Kioxia ID are the same. */  
> >>   #define SPINAND_MFR_TOSHIBA		0x98
> >>   #define TOSH_STATUS_ECC_HAS_BITFLIPS_T	(3 << 4)  
> >>   >  
> > "Are the same" is not very descriptive, what about "Kioxia is the new
> > name of Toshiba"?  
> 
> 
> That's a good idea.
> 
> Actually ,
> 
> Is was changed a company name from Toshiba memory Co to Kioxia Co.ÂÂÂÂ Since became independent from Toshiba group.
> 
> I will update the comment as "Kioxia is new name of Toshiba memory"

Well, in this case I would even recommend something more meaningful:

"Since its independence from Toshiba Group, Toshiba memory Co has become Kioxia Co"

Also, please update the version of your patch to "v3" in the title
"[PATCH v3] ...", this can be done automatically when formatting your
patch with git format-patch with the -v 3 option.

Also the prefix should be "mtd: spinand: toshiba:"

Thanks,
MiquÃl