Re: [PATCH] of: clk: Make <linux/of_clk.h> self-contained
From: Stephen Boyd
Date: Wed Feb 05 2020 - 17:51:48 EST
Quoting Geert Uytterhoeven (2020-02-05 11:46:49)
> Depending on include order:
>
> include/linux/of_clk.h:11:45: warning: \u2018struct device_node\u2019 declared inside parameter list will not be visible outside of this definition or declaration
> unsigned int of_clk_get_parent_count(struct device_node *np);
> ^~~~~~~~~~~
> include/linux/of_clk.h:12:43: warning: \u2018struct device_node\u2019 declared inside parameter list will not be visible outside of this definition or declaration
> const char *of_clk_get_parent_name(struct device_node *np, int index);
> ^~~~~~~~~~~
> include/linux/of_clk.h:13:31: warning: \u2018struct of_device_id\u2019 declared inside parameter list will not be visible outside of this definition or declaration
> void of_clk_init(const struct of_device_id *matches);
> ^~~~~~~~~~~~
>
> Fix this by adding forward declarations for struct device_node and
> struct of_device_id.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> Noticed when cleaning up some platform code.
> I am not aware of this being triggered in upstream, but this will become a
> dependency for these cleanups.
So apply for fixes? I'll just throw it in now.
Applied to clk-next.