Re: [PATCH 2/5] mm/memremap_pages: Introduce memremap_compat_align()

[Aneesh Kumar K.V]

On 2/6/20 11:21 AM, Dan Williams wrote:
....

> > > Link: http://lore.kernel.org/r/CAPcyv4gBGNP95APYaBcsocEa50tQj9b5h__83vgngjq3ouGX_Q@xxxxxxxxxxxxxx
> > > Reported-by: Aneesh Kumar K.V <aneesh.kumar@xxxxxxxxxxxxx>
> > > Reported-by: Jeff Moyer <jmoyer@xxxxxxxxxx>
> > > Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> > > Cc: Paul Mackerras <paulus@xxxxxxxxx>
> > > Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> > > Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> > > ---
> > >   arch/powerpc/include/asm/io.h |   10 ++++++++++
> > >   drivers/nvdimm/pfn_devs.c     |    2 +-
> > >   include/linux/io.h            |   23 +++++++++++++++++++++++
> > >   include/linux/mmzone.h        |    1 +
> > >   4 files changed, 35 insertions(+), 1 deletion(-)
> >
> > The powerpc change here looks fine to me.
> >
> > Acked-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx> (powerpc)
>
> Thanks Michael, unfortunately the kbuild robot just woke up and said
> that mips does not like including mmzone.h from io.h. The
> entanglements look intractable.
>
> Is there a file I can stash a strong definition of
> memremap_compat_align(), maybe arch/powerpc/mm/mem.c? Then I can put a
> generic __weak definition in mm/memremap.c rather than play header
> file include games.


arch/powerpc/mm/ioremap.c ?

-aneesh