Re: [PATCHv2 2/2] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150

[Sai Prakash Ranjan]

Hi Rob,

On 2020-02-07 00:08, Rob Herring wrote:
> On Sat, Feb 01, 2020 at 08:59:49PM +0530, Sai Prakash Ranjan wrote:
> > Add missing compatible for watchdog timer on QCS404,
> > SC7180, SDM845 and SM8150 SoCs.
>
> That's not what the commit does. You are changing what's valid.
>
> One string was valid, now 2 are required.

Does this look good?

diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml 
b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
index 46d6aad5786a..3378244b67cd 100644
--- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
@@ -14,19 +14,22 @@ allOf:

 properties:
   compatible:
-    items:
+    oneOf:
       - enum:
           - qcom,apss-wdt-qcs404
           - qcom,apss-wdt-sc7180
           - qcom,apss-wdt-sdm845
           - qcom,apss-wdt-sm8150
-          - qcom,kpss-timer
-          - qcom,kpss-wdt
           - qcom,kpss-wdt-apq8064
           - qcom,kpss-wdt-ipq4019
           - qcom,kpss-wdt-ipq8064
           - qcom,kpss-wdt-msm8960
+          - qcom,kpss-timer
+          - qcom,kpss-wdt
           - qcom,scss-timer
+      - const: qcom,kpss-timer
+      - const: qcom,kpss-wdt
+      - const: qcom,scss-timer

   reg:
     maxItems: 1

Thanks,
Sai

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member
of Code Aurora Forum, hosted by The Linux Foundation