Re: [PATCH v4 1/3] dt-bindings: one file of all simple DSI panels

[Philippe CORNU]

Hi Benjamin,
and many thanks for this serie.
Regarding this patch:

Reviewed-by: Philippe Cornu <philippe.cornu@xxxxxx>
Philippe :-)

On 2/6/20 2:33 PM, Benjamin Gaignard wrote:
> From: Sam Ravnborg <sam@xxxxxxxxxxxx>
> 
> To complement panel-simple.yaml, create panel-simple-dsi.yaml.
> panel-simple-dsi-yaml are for all simple DSP panels with a single
> power-supply and optional backlight / enable GPIO.
> 
> Migrate panasonic,vvx10f034n00 over to the new file.
> 
> The objectives with one file for all the simple DSI panels are:
>      - Make it simpler to add bindings for simple DSI panels
>      - Keep the number of bindings file lower
>      - Keep the binding documentation for simple DSI panels more consistent
> 
> Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxx>
> Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> Cc: Rob Herring <robh@xxxxxxxxxx>
> Cc: Maxime Ripard <mripard@xxxxxxxxxx>
> Cc: Yannick Fertre <yannick.fertre@xxxxxx>
> Cc: Mark Rutland <mark.rutland@xxxxxxx>
> Cc: Daniel Vetter <daniel@xxxxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: devicetree@xxxxxxxxxxxxxxx
> ---
> version 4:
> - remove orisetech,otm8009a and raydium,rm68200 compatibles
> - remove reset-gpios optional property
> 
> version 3:
> - add orisetech,otm8009a and raydium,rm68200 compatibles
> - add reset-gpios optional property
> - fix indentation on compatible enumeration
> 
>   .../display/panel/panasonic,vvx10f034n00.txt       | 20 -------
>   .../bindings/display/panel/panel-simple-dsi.yaml   | 67 ++++++++++++++++++++++
>   2 files changed, 67 insertions(+), 20 deletions(-)
>   delete mode 100644 Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt
>   create mode 100644 Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt b/Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt
> deleted file mode 100644
> index 37dedf6a6702..000000000000
> --- a/Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt
> +++ /dev/null
> @@ -1,20 +0,0 @@
> -Panasonic 10" WUXGA TFT LCD panel
> -
> -Required properties:
> -- compatible: should be "panasonic,vvx10f034n00"
> -- reg: DSI virtual channel of the peripheral
> -- power-supply: phandle of the regulator that provides the supply voltage
> -
> -Optional properties:
> -- backlight: phandle of the backlight device attached to the panel
> -
> -Example:
> -
> -	mdss_dsi@fd922800 {
> -		panel@0 {
> -			compatible = "panasonic,vvx10f034n00";
> -			reg = <0>;
> -			power-supply = <&vreg_vsp>;
> -			backlight = <&lp8566_wled>;
> -		};
> -	};
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> new file mode 100644
> index 000000000000..8b60368a2425
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> @@ -0,0 +1,67 @@
> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/panel-simple-dsi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Simple DSI panels with a single power-supply
> +
> +maintainers:
> +  - Thierry Reding <thierry.reding@xxxxxxxxx>
> +  - Sam Ravnborg <sam@xxxxxxxxxxxx>
> +
> +description: |
> +  This binding file is a collection of the DSI panels that
> +  requires only a single power-supply.
> +  There are optionally a backlight and an enable GPIO.
> +  The panel may use an OF graph binding for the association to the display,
> +  or it may be a direct child node of the display.
> +
> +  If the panel is more advanced a dedicated binding file is required.
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +
> +  compatible:
> +    enum:
> +      # compatible must be listed in alphabetical order, ordered by compatible.
> +      # The description in the comment is mandatory for each compatible.
> +
> +        # Panasonic 10" WUXGA TFT LCD panel
> +      - panasonic,vvx10f034n00
> +
> +  reg:
> +    maxItems: 1
> +    description: DSI virtual channel
> +
> +  backlight: true
> +  enable-gpios: true
> +  port: true
> +  power-supply: true
> +
> +additionalProperties: false
> +
> +required:
> +  - compatible
> +  - power-supply
> +  - reg
> +
> +examples:
> +  - |
> +    mdss_dsi@fd922800 {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +      panel@0 {
> +        compatible = "panasonic,vvx10f034n00";
> +        reg = <0>;
> +        power-supply = <&vcc_lcd_reg>;
> +
> +        port {
> +          panel: endpoint {
> +            remote-endpoint = <&ltdc_out>;
> +          };
> +        };
> +      };
> +    };
>