Re: [PATCH v3 1/3] dt-bindings: clock: Add YAML schemas for the QCOM MSS clock bindings

[Taniya Das]

On 2/7/2020 12:57 PM, Sibi Sankar wrote:
> Hey Taniya,
>
> On 2020-01-30 09:48, Taniya Das wrote:
> > The Modem Subsystem clock provider have a bunch of generic properties
> > that are needed in a device tree. Add a YAML schemas for those.
> >
> > Signed-off-by: Taniya Das <tdas@xxxxxxxxxxxxxx>
> > ---
> > Â.../devicetree/bindings/clock/qcom,mss.yamlÂÂÂÂÂÂÂ | 58 
> > ++++++++++++++++++++++
> > Â1 file changed, 58 insertions(+)
> > Âcreate mode 100644 Documentation/devicetree/bindings/clock/qcom,mss.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/clock/qcom,mss.yaml
> > b/Documentation/devicetree/bindings/clock/qcom,mss.yaml
> > new file mode 100644
> > index 0000000..ebb04e1
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/qcom,mss.yaml
> > @@ -0,0 +1,58 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/bindings/clock/qcom,mss.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm Modem Clock Controller Binding
> > +
> > +maintainers:
> > +Â - Taniya Das <tdas@xxxxxxxxxxxxxx>
> > +
> > +description: |
> > +Â Qualcomm modem clock control module which supports the clocks.
> > +
> > +properties:
> > +Â compatible:
> > +ÂÂÂ enum:
> > +ÂÂÂÂÂÂ - qcom,sc7180-mss
> > +
> > +Â clocks:
> > +ÂÂÂ minItems: 1
> > +ÂÂÂ maxItems: 3
> > +ÂÂÂ items:
> > +ÂÂÂÂÂ - description: gcc_mss_mfab_axi clock from GCC
> > +ÂÂÂÂÂ - description: gcc_mss_nav_axi clock from GCC
>
> we don't seem to be referencing the
> mss_mfab_axi and mss_nav_axi in the
> mss clk driver though, do we really
> need them in bindings? If we dont
> can we drop the clock-names as well.

They are linked as parent for the clocks. So we need them.
+			.parent_data = &(const struct clk_parent_data){
+				.fw_name = "gcc_mss_nav_axi_clk",
+			},

> > +ÂÂÂÂÂ - description: gcc_mss_cfg_ahb clock from GCC
> > +
> > +Â clock-names:
> > +ÂÂÂ items:
> > +ÂÂÂÂÂ - const: gcc_mss_mfab_axis_clk
> > +ÂÂÂÂÂ - const: gcc_mss_nav_axi_clk
> > +ÂÂÂÂÂ - const: cfg_clk
> > +
> > +Â '#clock-cells':
> > +ÂÂÂ const: 1
> > +
> > +Â reg:
> > +ÂÂÂ maxItems: 1
> > +
> > +required:
> > +Â - compatible
> > +Â - reg
> > +Â - clocks
> > +Â - '#clock-cells'
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +Â # Example of MSS with clock nodes properties for SC7180:
> > +Â - |
> > +ÂÂÂ clock-controller@41a8000 {
> > +ÂÂÂÂÂ compatible = "qcom,sc7180-mss";
> > +ÂÂÂÂÂ reg = <0x041a8000 0x8000>;
> > +ÂÂÂÂÂ clocks = <&gcc 126>, <&gcc 127>, <&gcc 125>;
> > +ÂÂÂÂÂ clock-names = "gcc_mss_mfab_axis_clk", "gcc_mss_nav_axi_clk", 
> > "cfg_clk";
> > +ÂÂÂÂÂ #clock-cells = <1>;
> > +ÂÂÂ };
> > +...
> > --
> > Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
> > of the Code Aurora Forum, hosted by the Linux Foundation.

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--