Re: [PATCH] kconfig: fix broken dependency in randconfig-generated .config

[Vincenzo Frascino]

On 01/02/2020 05:11, Masahiro Yamada wrote:
> On Sat, Feb 1, 2020 at 2:03 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
>>
>> Running randconfig on arm64 using KCONFIG_SEED=0x40C5E904 (e.g. on v5.5)
>> produces the .config with CONFIG_EFI=y and CONFIG_CPU_BIG_ENDIAN=y,
>> which does not meet the !CONFIG_CPU_BIG_ENDIAN dependency.
>>
>> This is because the user choice for CONFIG_CPU_LITTLE_ENDIAN vs
>> CONFIG_CPU_BIG_ENDIAN is set by randomize_choice_values() after the
>> value of CONFIG_EFI is calculated.
>>
>> When this happens, the has_changed flag should be set.
>>
>> Currently, it takes the result from the last iteration. It should
>> accumulate all the results of the loop.
>>
>> Reported-by: Vincenzo Frascino <vincenzo.frascino@xxxxxxx>
>> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
>> ---
> 
> Maybe, this could be tagged:
> 
> Fixes: 3b9a19e08960 ("kconfig: loop as long as we changed some symbols
> in randconfig")
> 
> 
>

Reviewed-by: Vincenzo Frascino <vincenzo.frascino@xxxxxxx>

> 
> 
>>  scripts/kconfig/confdata.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
>> index 99f2418baa6c..eb1efa3abdee 100644
>> --- a/scripts/kconfig/confdata.c
>> +++ b/scripts/kconfig/confdata.c
>> @@ -1353,7 +1353,7 @@ bool conf_set_all_new_symbols(enum conf_def_mode mode)
>>
>>                 sym_calc_value(csym);
>>                 if (mode == def_random)
>> -                       has_changed = randomize_choice_values(csym);
>> +                       has_changed |= randomize_choice_values(csym);
>>                 else {
>>                         set_all_choice_values(csym);
>>                         has_changed = true;
>> --
>> 2.17.1
>>
> 
> 

-- 
Regards,
Vincenzo

Attachment: pEpkey.asc
Description: application/pgp-keys