Re: [PATCH 11/28] ata: add CONFIG_SATA_HOST=n version of ata_ncq_enabled()

[Bartlomiej Zolnierkiewicz]

On 1/29/20 6:24 PM, Christoph Hellwig wrote:
>>  static inline int ata_ncq_enabled(struct ata_device *dev)
>>  {
>> +#ifdef CONFIG_SATA_HOST
>>  	return (dev->flags & (ATA_DFLAG_PIO | ATA_DFLAG_NCQ_OFF |
>>  			      ATA_DFLAG_NCQ)) == ATA_DFLAG_NCQ;
>> +#else
>> +	return 0;
>> +#endif
> 
> I think this is a prime candidate for IS_ENABLED:
> 
> 	if (!IS_ENABLED(CONFIG_SATA_HOST))
> 		return 0;
>  	return (dev->flags & (ATA_DFLAG_PIO | ATA_DFLAG_NCQ_OFF |
>   			      ATA_DFLAG_NCQ)) == ATA_DFLAG_NCQ;
> 

Fully agreed, fixed in v2.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics