Re: [PATCH 13/28] ata: move ata_do_link_spd_horkage() to libata-core-sata.c

[Bartlomiej Zolnierkiewicz]

On 1/29/20 6:28 PM, Christoph Hellwig wrote:
> On Tue, Jan 28, 2020 at 02:33:28PM +0100, Bartlomiej Zolnierkiewicz wrote:
>> * move ata_do_link_spd_horkage() to libata-core-sata.c
>>
>> * add static inline for CONFIG_SATA_HOST=n case
> 
> Wouldn't it make more sense to stub out sata_scr_valid for the !SATA
> case and just let the compiler optimize the function away now that it
> can't be called in that case?

I've reworked the code to use this approach in v2 of the patchset.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics