Re: [PATCH v5 09/18] usb: dwc3: qcom: Add support for usb-conn-gpio connectors

[Bryan O'Donoghue]

On 07/02/2020 20:43, Jack Pham wrote:
> Hi Bryan,
>
> On Fri, Feb 07, 2020 at 08:16:45PM +0000, Bryan O'Donoghue wrote:
> > This patch adds a routine to find a usb-conn-gpio in the main DWC3 code.
> > This will be useful in a subsequent patch where we will reuse the current
> > extcon VBUS notifier with usb-conn-gpio.
> >
> > ---
> >   drivers/usb/dwc3/dwc3-qcom.c | 15 +++++++++++++++
> >   1 file changed, 15 insertions(+)
> >
> > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> > index 261af9e38ddd..fc66ca3316ef 100644
> > --- a/drivers/usb/dwc3/dwc3-qcom.c
> > +++ b/drivers/usb/dwc3/dwc3-qcom.c
> > @@ -550,6 +550,21 @@ static const struct dwc3_acpi_pdata sdm845_acpi_pdata = {
> >   	.ss_phy_irq_index = 2
> >   };
> >   
> > +static bool dwc3_qcom_find_gpio_usb_connector(struct platform_device *pdev)
>
> Why not just squash this patch into "[PATCH v5 12/18] usb: dwc3: qcom:
> Enable gpio-usb-conn based role-switching" where it is actually used?

IMO its best practice to have smaller patches.

This one adds the routine.
12/18 uses the routine but also

- Triggers a notifer role-switch binding
- Adds an if/else for extcon

Believe it or not I had an internal debate about splitting #12 into two 
patches !

---
bod