Re: [PATCH v2 3/9] ASoC: tegra: add Tegra210 based DMIC driver

[Dmitry Osipenko]

07.02.2020 14:06, Sameer Pujar ÐÐÑÐÑ:
> 
> 
> On 2/6/2020 10:23 PM, Dmitry Osipenko wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> 30.01.2020 13:33, Sameer Pujar ÐÐÑÐÑ:
>> ...
>>> +static const struct reg_default tegra210_dmic_reg_defaults[] = {
>>> +ÂÂÂÂ { TEGRA210_DMIC_TX_INT_MASK, 0x00000001},
>>> +ÂÂÂÂ { TEGRA210_DMIC_TX_CIF_CTRL, 0x00007700},
>>> +ÂÂÂÂ { TEGRA210_DMIC_CG, 0x1},
>>> +ÂÂÂÂ { TEGRA210_DMIC_CTRL, 0x00000301},
>>> +ÂÂÂÂ /* Below enables all filters - DCR, LP and SC */
>>> +ÂÂÂÂ { TEGRA210_DMIC_DBG_CTRL, 0xe },
>>> +ÂÂÂÂ /* Below as per latest POR value */
>>> +ÂÂÂÂ { TEGRA210_DMIC_DCR_BIQUAD_0_COEF_4, 0x0},
>>> +ÂÂÂÂ /* LP filter is configured for pass through and used to apply
>>> gain */
>>> +ÂÂÂÂ { TEGRA210_DMIC_LP_BIQUAD_0_COEF_0, 0x00800000},
>>> +ÂÂÂÂ { TEGRA210_DMIC_LP_BIQUAD_0_COEF_1, 0x0},
>>> +ÂÂÂÂ { TEGRA210_DMIC_LP_BIQUAD_0_COEF_2, 0x0},
>>> +ÂÂÂÂ { TEGRA210_DMIC_LP_BIQUAD_0_COEF_3, 0x0},
>>> +ÂÂÂÂ { TEGRA210_DMIC_LP_BIQUAD_0_COEF_4, 0x0},
>>> +ÂÂÂÂ { TEGRA210_DMIC_LP_BIQUAD_1_COEF_0, 0x00800000},
>>> +ÂÂÂÂ { TEGRA210_DMIC_LP_BIQUAD_1_COEF_1, 0x0},
>>> +ÂÂÂÂ { TEGRA210_DMIC_LP_BIQUAD_1_COEF_2, 0x0},
>>> +ÂÂÂÂ { TEGRA210_DMIC_LP_BIQUAD_1_COEF_3, 0x0},
>>> +ÂÂÂÂ { TEGRA210_DMIC_LP_BIQUAD_1_COEF_4, 0x0},
>>> +};
>> I'd add a space on the right side of `}`, for consistency with the left.
> 
> Do you mean like this?
> { TEGRA210_DMIC_TX_INT_MASK, 0x00000001 },
> { TEGRA210_DMIC_TX_CIF_CTRL, 0x00007700 },
> ÂÂÂ . . .

Yes