Re: [PATCH 2/3] media: vimc: Add GBR media bus code

[NÃcolas F. R. A. Prado]

Hi Helen,

thank you for the review.

Please see my comment below.

On Wed, Feb 05, 2020 at 11:17:35AM -0300, Helen Koike wrote:
> 
> Hi NÃcolas,
> 
> Thank you for the patch.
> 
> On 2/2/20 1:50 PM, NÃcolas F. R. A. Prado wrote:
> > Add missing GBR888_1X24 media bus code in the vimc_pix_map_list. Since
> > there is no pixel format for it, use the pixelformat for RGB.
> >
> > Co-developed-by: Vitor Massaru Iha <vitor@xxxxxxxxxxx>
> > Signed-off-by: Vitor Massaru Iha <vitor@xxxxxxxxxxx>
> > Signed-off-by: NÃcolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxxx>
> > ---
> >  drivers/media/platform/vimc/vimc-common.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/platform/vimc/vimc-common.c b/drivers/media/platform/vimc/vimc-common.c
> > index 55797e5ab2b1..591a50f63766 100644
> > --- a/drivers/media/platform/vimc/vimc-common.c
> > +++ b/drivers/media/platform/vimc/vimc-common.c
> > @@ -25,7 +25,7 @@ static const struct vimc_pix_map vimc_pix_map_list[] = {
> >  		.bayer = false,
> >  	},
> >  	{
> > -		.code = {MEDIA_BUS_FMT_RGB888_1X24},
> > +		.code = {MEDIA_BUS_FMT_RGB888_1X24, MEDIA_BUS_FMT_GBR888_1X24},
> 
> Could you add spaces around the curly brackets here too?
> 
> I was also thinking that all the MEDIA_BUS_FMT_RGB888_* and MEDIA_BUS_FMT_GBR888_* variants
> could be added here (to be verified).

Now that you said it, it does seem that this could be done.

>From the pixelformat definitions on [1], there is a single format definition for
RGB-8-8-8 and for BGR-8-8-8:

#define V4L2_PIX_FMT_BGR24   v4l2_fourcc('B', 'G', 'R', '3') /* 24  BGR-8-8-8     */
#define V4L2_PIX_FMT_RGB24   v4l2_fourcc('R', 'G', 'B', '3') /* 24  RGB-8-8-8     */

This probably means that all media bus code variants of RGB888 should map to the
same RGB888 pixelformat. Same for BGR888.

So, should I go on and send a v2 adding these other formats or should we wait
for others to comment on this first?

Thanks,
NÃcolas

[1] https://elixir.bootlin.com/linux/latest/source/include/uapi/linux/videodev2.h#L549

> 
> Thanks
> Helen
> 
> >  		.pixelformat = V4L2_PIX_FMT_RGB24,
> >  		.bpp = 3,
> >  		.bayer = false,
> >