Re: [PATCH v4 0/3] drm: Add support for Cadence MHDP DPI/DP bridge and J721E wrapper.

[Jyri Sarha]

On 06/02/2020 08:29, Yuti Amonkar wrote:
> This patch series adds new DRM driver for Cadence Display Port.
> The Cadence Display Port is also referred as MHDP (Mobile High
> Definition Link, High-Definition Multimedia Interface Display
> Port) Cadence Display Port complies with VESA DisplayPort (DP)
> and embedded Display Port (eDP) standards. This driver implements
> Single Stream Transport (SST) support. Adds Texas Instruments SoC
> J721e specific wrapper and adds the device tree bindings in YAML format.
> 
> The patch series has three patches which applies the changes in the below sequence
> 1. 001-dt-bindings-drm-bridge-Document-Cadence-MHDP-bridge-bindings
> Documents the bindings in yaml format.
> 2. 002-drm-bridge-Add-support-for-Cadence-MHDP-bridge
> This patch adds new DRM driver for Cadence MHDP Display Port. The patch implements supports
> for single stream transport mode.
> 3. 003-drm-bridge-cdns-mhdp-add-j721e-wrapper
> Add Texas Instruments (TI) j721e wrapper for mhdp. The wrapper configures mhdp clocks
> and muxes as required by SoC.
> 

For the whole series:
Tested-by: Jyri Sarha <jsarha@xxxxxx>
Reviewed-by: Jyri Sarha <jsarha@xxxxxx

Or maybe for the code patches it should be:
Signed-off-by: Jyri Sarha <jsarha@xxxxxx>

As a number of code lines are written by me.

Best regards,
Jyri

> Version History:
> 
> v4:
> - Added SPDX dual license tag to YAML bindings.
> - Corrected indentation of the child node properties.
> - Removed the maxItems in the conditional statement.
> - Removed phy-names property from the bindings.
> - Add Reviewed-by: Rob Herring <robh@xxxxxxxxxx> tag to the
>   "Document Cadence MHDP bridge bindings" patch.
> - Renamed the DRM driver executable name from mhdp8546 to cdns-mhdp in Makefile.
> - Renamed the DRM driver and header file from cdns-mhdp to cdns-mhdp-core.
> 
> v3:
> - Added if / then clause to validate that the reg length is proper
>   based on the value of the compatible property.
> - Updated phy property description in YAML to a generic one.
> - Renamed num_lanes and max_bit_rate property strings to cdns,num-lanes 
>   and cdns,max-bit-rate based on update in PHY series [2].
> 
> v2:
> - Use enum in compatible property of YAML file.
> - Add reg-names property to YAML file
> - Add minItems and maxItems to reg property in YAML.
> - Remove cdns_mhdp_link_probe function to remove
>   duplication of reading dpcd capabilities.
> 
> This patch series is dependent on PHY DisplayPort configuration patch [1]
> 
> [1]
> 
> https://lkml.org/lkml/2020/1/6/279
> 
> [2]
> 
> https://lkml.org/lkml/2020/2/6/15
> 
> 
> Yuti Amonkar (3):
>   dt-bindings: drm/bridge: Document Cadence MHDP bridge bindings.
>   drm: bridge: Add support for Cadence MHDP DPI/DP bridge
>   drm: bridge: cdns-mhdp: add j721e wrapper
> 
>  .../bindings/display/bridge/cdns,mhdp.yaml    |  125 +
>  drivers/gpu/drm/bridge/Kconfig                |   23 +
>  drivers/gpu/drm/bridge/Makefile               |    6 +
>  drivers/gpu/drm/bridge/cdns-mhdp-core.c       | 2220 +++++++++++++++++
>  drivers/gpu/drm/bridge/cdns-mhdp-core.h       |  381 +++
>  drivers/gpu/drm/bridge/cdns-mhdp-j721e.c      |   79 +
>  drivers/gpu/drm/bridge/cdns-mhdp-j721e.h      |   55 +
>  7 files changed, 2889 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/bridge/cdns,mhdp.yaml
>  create mode 100644 drivers/gpu/drm/bridge/cdns-mhdp-core.c
>  create mode 100644 drivers/gpu/drm/bridge/cdns-mhdp-core.h
>  create mode 100644 drivers/gpu/drm/bridge/cdns-mhdp-j721e.c
>  create mode 100644 drivers/gpu/drm/bridge/cdns-mhdp-j721e.h
> 


-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki