Re: [PATCH v2 6/9] ASoC: tegra: add Tegra186 based DSPK driver

[Sameer Pujar]

On 2/7/2020 11:52 PM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> 07.02.2020 14:26, Sameer Pujar ÐÐÑÐÑ:
> > On 2/6/2020 10:45 PM, Dmitry Osipenko wrote:
> > > External email: Use caution opening links or attachments
> > >
> > >
> > > 30.01.2020 13:33, Sameer Pujar ÐÐÑÐÑ:
> > > > +static const struct dev_pm_ops tegra186_dspk_pm_ops = {
> > > > +     SET_RUNTIME_PM_OPS(tegra186_dspk_runtime_suspend,
> > > > +                        tegra186_dspk_runtime_resume, NULL)
> > > > +     SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
> > > > +                                  pm_runtime_force_resume)
> > > > +};
> > > Could you please explain why drivers need the "late" system sleep?
> > It was done to ensure core drivers are suspended first and defer the
> > codec driver suspend
> Suspend order is opposite to the drivers registration order. If there is
> no real problem with that, then you should use the default suspend

> level. Please don't try to fix a non-existent problems.

No. This was done specifically to allow sound core to first stop any 
ongoing audio activity during normal suspend and ensure a safe suspend 
of AHUB devices by doing a LATE suspend.