Re: [PATCH] tools/bootconfig: Fix wrong __VA_ARGS__ usage

From: Steven Rostedt
Date: Mon Feb 10 2020 - 12:07:36 EST


On Mon, 10 Feb 2020 20:50:42 +1100
Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:

> > diff --git a/tools/bootconfig/include/linux/printk.h b/tools/bootconfig/include/linux/printk.h
> > index 017bcd6912a5..e978a63d3222 100644
> > --- a/tools/bootconfig/include/linux/printk.h
> > +++ b/tools/bootconfig/include/linux/printk.h
> > @@ -7,7 +7,7 @@
> > /* controllable printf */
> > extern int pr_output;
> > #define printk(fmt, ...) \
> > - (pr_output ? printf(fmt, __VA_ARGS__) : 0)
> > + (pr_output ? printf(fmt, ##__VA_ARGS__) : 0)
> >
> > #define pr_err printk
> > #define pr_warn printk
>
> Tested-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>

Thanks! I'll rebase my branch with this.

-- Steve