Re: [PATCH v2 3/8] ASoC: qdsp6: q6afe-dai: add support to pcm port dais

From: Srinivas Kandagatla
Date: Mon Feb 10 2020 - 12:41:05 EST




On 10/02/2020 17:22, Adam Serbinski wrote:


Why are we adding exactly duplicate function of q6afe_mi2s_set_sysclk here?

It isn't an exact duplicate.

The reason I split off the new function is because the clock IDs for PCM
overlap/duplicate the clock IDs for TDM, yet the parameters to
q6afe_port_set_sysclk are not the same for PCM and TDM.

we should be able to use dai->id to make that decision.

--srini





 + SND_SOC_DAPM_AIF_IN("QUAT_PCM_RX", NULL,
+ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ 0, 0, 0, 0),