Re: [PATCH v3] tools/perf/metricgroup: Fix printing event names of metric group with multiple events incase of overlapping events

From: Andi Kleen
Date: Mon Feb 10 2020 - 13:00:49 EST


> > stack declarations of variable length arrays are not
> > a good thing.
> >
> > https://lwn.net/Articles/749089/
> >
> > and
> >
> > bool evlist_used[perf_evlist->core.nr_entries] = {};
>
> hum, I think we already have few of them in perf ;-)

For user space they don't really matter as long as the size is
not totally out of bound, it has a fairly large stack compared
to the kernel, and also is less security sensitive.

-Andi