Re: [PATCH v1] kbuild: Fix off-by-one error when generate a new version

From: Andy Shevchenko
Date: Mon Feb 10 2020 - 15:23:27 EST


On Mon, Feb 10, 2020 at 10:15 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
> On Mon, Jan 27, 2020 at 7:05 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > On Fri, Jan 24, 2020 at 09:58:59PM +0200, Andy Shevchenko wrote:

...

> > > Additionally provide a unified way to get the current version of the build
> > > and use this in few callers. This will respect the KBUILD_BUILD_VERSION
> > > in case it's provided.

I still think there is second part in my patch to be considered, i.e. see above.

...

> I remember I was also hit by this one month ago or so.
>
> I did not dig into it at that time
> because the problem disappeared after doing something.
>
> Today, I took a look at this again.
> This is a regression caused by 56d589361572
>
> This patch should fix it:
> https://patchwork.kernel.org/patch/11374047/

Thank you.

--
With Best Regards,
Andy Shevchenko