Re: [PATCH 1/3] objtool: Fail the kernel build on fatal errors

[Julien Thierry]

On 2/10/20 6:32 PM, Josh Poimboeuf wrote:
> When objtool encounters a fatal error, it usually means the binary is
> corrupt or otherwise broken in some way.  Up until now, such errors were
> just treated as warnings which didn't fail the kernel build.
>
> However, objtool is now stable enough that if a fatal error is
> discovered, it most likely means something is seriously wrong and it
> should fail the kernel build.
>
> Note that this doesn't apply to "normal" objtool warnings; only fatal
> ones.
>
> Suggested-by: Borislav Petkov <bp@xxxxxxx>
> Signed-off-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>

Reviewed-by: Julien Thierry <jthierry@xxxxxxxxxx>

> ---
>   tools/objtool/check.c | 12 +++++++++---
>   1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> index b6da413bcbd6..61d2d1877fd2 100644
> --- a/tools/objtool/check.c
> +++ b/tools/objtool/check.c
> @@ -2509,8 +2509,14 @@ int check(const char *_objname, bool orc)
>   out:
>   	cleanup(&file);
>   
> -	/* ignore warnings for now until we get all the code cleaned up */
> -	if (ret || warnings)
> -		return 0;
> +	if (ret < 0) {
> +		/*
> +		 *  Fatal error.  The binary is corrupt or otherwise broken in
> +		 *  some way, or objtool itself is broken.  Fail the kernel
> +		 *  build.
> +		 */
> +		return ret;
> +	}
> +
>   	return 0;
>   }

--
Julien Thierry