Re: [PATCH 2/2] ALSA: hda/realtek - Fix Lenovo Thinkpad X1 Carbon 7th quirk value

From: Jaroslav Kysela
Date: Tue Feb 11 2020 - 04:35:29 EST


Dne 11. 02. 20 v 9:16 Benjamin Poirier napsal(a):
On 2020/02/11 08:40 +0100, Jaroslav Kysela wrote:
[...]

In summary, Node 0x17 DAC connection 0x3 offers the loudest max volume and
the most detailed mixer controls. That connection is obtained with quirk
ALC295_FIXUP_DISABLE_DAC3. Therefore, change the ThinkPad X1 Carbon 7th to
use ALC295_FIXUP_DISABLE_DAC3.

The volume split (individual volume control) will cause trouble for the UCM
volume control at the moment which is the target for this device to get the
digital microphone working. If there is no possibility to share DAC, it
would be probably more nice to join the volume control in the driver.

Have you tried to use 0x03 as source for all four speakers?

Front speakers are fixed to 0x02. Node 0x14
Connection: 1
0x02


Yes, you're right. I forgot that.


Why PA handles the rear volume control with the current driver code in the
legacy ALSA driver? It should be handled like standard stereo device. I'll
check.

The device comes up with "Analog Stereo Output" profile by default. I
changed it to "Analog Surround 4.0 Output" to test controlling each
channel individually:

Yes, but does the volume control work (does PA change the appropriate ALSA mixer volume)? Sometimes, it's difficult to see the difference between soft volume attenuation and the hardware volume control.


pavucontrol controls are reported with the device configured with the
"Analog Surround 4.0 Output" profile.


You should also test PA with UCM.

Please let me know what do I need to test exactly? I'm not familiar with
UCM.

Just install the latest pulseaudio (latest from repo), alsa-lib and alsa-ucm-conf (also from repo). If pulseaudio detects UCM, it has the preference.

Jaroslav




--
Jaroslav Kysela <perex@xxxxxxxx>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.