Re: [[PATCH staging] 3/7] staging: wfx: fix init/remove vs IRQ race

[Michał Mirosław]

On Tue, Feb 11, 2020 at 12:23:54PM +0300, Dan Carpenter wrote:
> On Tue, Feb 11, 2020 at 09:46:54AM +0100, Michał Mirosław wrote:
> > @@ -234,8 +234,8 @@ static void wfx_sdio_remove(struct sdio_func *func)
> >  	struct wfx_sdio_priv *bus = sdio_get_drvdata(func);
> >  
> >  	wfx_release(bus->core);
> > -	wfx_free_common(bus->core);
> >  	wfx_sdio_irq_unsubscribe(bus);
>         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> This calls sdio_release_host(func);
> 
> > +	wfx_free_common(bus->core);
> >  	sdio_claim_host(func);
> >  	sdio_disable_func(func);
> >  	sdio_release_host(func);
>         ^^^^^^^^^^^^^^^^^^^^^^^^
> so is this a double free?

This is paired with sdio_claim_host() just above.

Best Regards,
Michał Mirosław